More options with config_circuit_breaker
Answeredconfig_circuit_breaker is a simple way of securing your node from a unintended wipe.
However as-is it only protects from deletes and not changes and the trigger is hard coded as 10% of configs. It would be grate if config_circuit_breaker had an option to trigger on number of changed configs and not only deleted, and that we could set this number our self.
Good security features are something we want as soon as possible :)
-
The only option now is:
global_defaults.use_config_circuit_breaker
true/false -
The configuration upload circuit breaker is very limited currently and it is hard coded to 10% changes when enabled. How exactly would you like to configure it to do what you want it to do? Can you post some example configuration options so that we see how you'd like to see it used?
-
Since config_circuit_breake is NOT related to datasets circuit breakers it makes sense to have distinctly different wording to set it.
https://docs.sesam.io/hub/documentation/service-configuration/pipes/configuration-sinks-dataset.html?highlight=circuit_breaker_threshold_countI think something like:
"config_circuit_breake_mode": None | "changed" | "deleted"
"config_circuit_breake_threshold": int | decimal
set in global metadata would make sense."config_circuit_breake_threshold" would be an integer bigger or equal to 1 if count was used and decimal from 0 to 1 if % threshold used.
If "config_circuit_breake_mode" is "changed", than unlike now threshold is related to all changed configs and not only deleted configs.E.g. settings:
"config_circuit_breake_mode": "deleted",
"config_circuit_breake_threshold": 0.1
would give the same result as:
"config_circuit_breaker": True
gives today.
Please sign in to leave a comment.
Comments
3 comments